On Sat, Sep 21, 2013 at 3:49 AM, Timothy Anderegg < [email protected]> wrote:
> Hi Luke - > > I just wanted to clarify the approach I'm using - The issue of whether or > not the EmailUser is in contrib.auth or in a new app contrib.auth_email is > a separate issue from code duplication. > This is a key point, and I think the whole conversation warrants a bit of a reboot. We have two key questions here: 1) Where does the new model live? Is it going to live in contrib.auth, or in a new contrib.email_auth package? 2) Exactly what does the new class hierarchy look like? Are we going to do any refactoring of AbstractUser? How many composable bits are we going to end up with? We've had a lot of discussion on question 1, which is risking becoming a bit of a bikeshed on the interpretation of `swappable`. What I haven't seen is a whole lot of clear discussion on point 2. Most of the discussion seems to stop at "use package/patch X", rather than a providing a good summary of the consequences. Correct me anyone disagrees, but my impression is that the endpoint isn't under dispute -- we're aiming at adding a new User model that is an exact analog of the existing User model, but with email as the USERNAME_FIELD. However, there are a couple of ways we can make this happen (ranging from simple copy/paste to a complex mixin/inheritance hierarchy). Speaking as the person from core who wants/needs to commit this, I need to see options for *this* part of the discussion. I've just put a summary of these two points on the wiki; I'd invite anyone with an opinion to weigh in. As always, try to remain impersonal and objective. I'd also appreciate people who have contributed to the 'Implementation' section to tie back to the new design section -- if you've proposed a codebase, describe which design decisions you've made. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
