formset.save(commit=False) on ModelFormSets currently deletes any objects marked for deletion which seems like a bug to me, since I wouldn't expect any data changing operations when using commit=False. I put together a pull request <https://github.com/django/django/pull/1351> to address #10284<https://code.djangoproject.com/ticket/10284> which includes a doc update indicating that it's backwards incompatible (bug fixes are) and how to account for the new behavior.
I then came across #17988 <https://code.djangoproject.com/ticket/17988>which takes a different approach by keeping the current behavior of formset.save(commit=False)deleting objects, but allowing you to call formset.save() a second time after calling formset.save(commit=False)[currently the second save() would throw an exception due to the objects being deleted on the first save(commit=False) call]. Curious to get other opinions. Thanks! -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
