On Saturday, May 18, 2013 5:57:49 AM UTC-7, Marc Tamlyn wrote: > > I'm going to resurrect this old thread as I'd like to get it resolved in > some fashion. > > I used to be very in favour of the class decorators approach. I've been > using an implementation of `@class_view_decorator(func)` for some time and > it works pretty well. That said my implementation at least was subject to a > notable flaw which is that if multiple parts of the hierarchy have the same > decorator applied to them then the check gets done twice. Mixins are much > cleverer than this because of MRO, so we avoid that problem. > > Mixins however have their own issues - it's "harder" (for some definition) > to ensure that all of your top-level permission checking happening in the > correct order. That said, I am certainly veering towards implementing this > using mixins (for each piece of functionality). > > I'd really like to have a look at Donald's implementation, sadly it seems > to no longer be on github. Do you still have then code somewhere, or can > you explain the implementation idea? >
Marc, ask and you shall receive. I've always been convinced this is the way to go: https://github.com/ptone/django/compare/mixin-decorators -P -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
