On Saturday 18 May 2013 19:35:31 Anssi Kääriäinen wrote: > On 18 touko, 17:46, Shai Berger <[email protected]> wrote: > > > > 1) The fixes I see would affect all backends, but AFAIK only Oracle is > > reported as failing the test; anyone wants to comment on this? Do all > > other backends just not need a cast_to_date operation? > > > > 2) Should I fix it in the ugly ways, or look for a more general solution, > > which will involve deeper changes? > > I don't think it is necessary to do deeper changes. My interpretation > of the current lookup system is that it has been stretched to its > limits and needs to be refactored. I intended to do that already for > the 1.6 release but ran out of steam. > > Of course, if you want to do improvements to current code that isn't > forbidden... But don't feel obligated to do so. > > I am not sure about question 1 except that changing the backend API to > make Oracle work is OK. > I'm toying with a different solution now -- removing the date casting on Oracle too. It passed the lookup tests, now I'm running the whole suite (that takes a little time). After seeing that no other backend in core does it, and as we do set the timestamp format, I wonder if it is really necessary. If that works, it's a pretty solution that affects Oracle only.
Shai. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
