Hi, Resurrecting a 4-month-old thread:
On Sunday 20 January 2013 10:05:16 Anssi Kääriäinen wrote: > On 20 tammi, 02:52, Shai Berger <[email protected]> wrote: > > Which still leaves two issues -- PR #393 (faster processign of numbers; I > > think I forgot to mention earlier -- it is just some fixes on work by Ian > > Kelly), and PR #411 (named parameters). > > > > Per Jani's PR#650 (which I just went to review and found already > > accepted), I note that the fix in #393 requires cx_Oracle 5.0.1; if it > > is accepted, the check for cx_Oracle major version >=5 can be removed > > (the requirement change comes from Ian's modifications, so it is > > apparently acceptable at least to one core developer). > > It would be nice to get the named parameters addition for every > backend, this would mean we can actually document that you can use > named parameters and expect it to work cross-db. > So -- does this mean that a patch adding named parameters on Oracle needs to also include tests and documentation of the "new feature" (it exists, undocumented, for other backends...)? Or is it just a "nice-to-have"? I'm asking because I have limited time to work on Oracle issues, and I suspect the current failing tests are higher priority. > For the faster processing of numbers... [...] if you want a patch to be seen > by me, then trac ticket + review is the way to go. I occasionally do commit > patches from other sources, but Trac ORM RFC queue is the main way. > Ticket #20414[0] and PR #1071[1]. Based on the fact that the code is based on Ian's patch, and the work[2] you (Anssi) and me have done on this together (as PR #393, last september), can I mark this ready-for-commit? Thanks, Shai. [0] https://code.djangoproject.com/ticket/20414 [1] https://github.com/django/django/pull/1071 [2] https://groups.google.com/d/topic/django-developers/4BNkJyGez9A/discussion -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
