On Thursday, April 18, 2013 8:46:02 PM UTC+2, Michael Manfre wrote: > > > > > On Thu, Apr 18, 2013 at 2:25 PM, Przemysław Suliga > <[email protected]<javascript:> > > wrote: > >> >> >> On Thursday, April 18, 2013 7:59:59 PM UTC+2, Michael Manfre wrote: >>> >>> - What should happen if not all of the filters on a ModelAdmin support >>> being incremental? Exception, allow some filters to yield empty results, or >>> some other behavior? >>> >> >> All default `FieldListFilter`s are supporting it (patch). >> >> As for custom FIlters - subclasses of `SimpleListFilter` - it could be >> made `incremental aware` but to make it really 'incremental' would be >> user's responsibility (and decision in the first place) ? >> > > It would be the user's responsibility, but what would be the actual > behavior with incremental and non-incremental filters on the same page? > What should Django do? How would the user know that their filters are not > all doing the same thing? >
Current implementation allows users to define custom filters that can behave differently from default `FieldListFilter` and Django isn't doing anything to prevvent it. One can define a custom filter which will act exactly as incremental filters which we discuss and if one mixes them with field list filters then their filters are not doing the same thing either. Should Django be restricting/warning users from implementing whatever logic with respect to 'incrementality' of their custom filters? -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
