On Thursday, March 28, 2013 1:50:36 PM UTC+1, Aymeric Augustin wrote:
>
>
> On 28 mars 2013, at 12:21, Stan <[email protected] <javascript:>>
> wrote:
>
> > Do you guys think it worth the effort to backport the functionality into
> admin ?
>
>
> Hi Stan,
>
> I like this idea.
>
> In terms of API, is there a particular reason why you chose to add an
> attribute to the actions themselves? I'd prefer to support a nested
> structure for ModelAdmin.actions, because it gives control on order of the
> groups and if feels more natural
Agreed. The first implementation was a nested tuple/list:
(
('group 1', ['actionA', 'actionB', ...]),
('group 2', ['actionX', 'actionY', ...]),
)
But it wasn't DRY enough because I had to maintain 2 structures of actions
(in the admin and in the front-end logic).
So I add that attribute - which is harmless - and process the
ModelAdmin.actions in the front-end.
Anyway,
The nested structure is certainly better option (with a fallback on the
simple list we are used to.)
---
Stanislas
— there's less action at a distance.
>
> --
> Aymeric.
>
>
>
>
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
