Hello,

I've integrated the feedback received on my initial proposal in a new pull 
request:
https://github.com/django/django/pull/733 and I think it's ready for review.

I'm just wondering if 10 minutes is a good default value for CONN_MAX_AGE.
I chose it randomly. Would "unlimited" be better?

Unfortunately, this code is difficult to test automatically, for two reasons:
- The testing framework needs a permanent database connection; it inhibits
  the closing of the connection triggered on request_started / request_finished.
- Database errors cannot be produced at will.

I've done some manual testing with gunicorn. Django recovers as expected
after a database restart, ie. one request fails and the next one succeeds.

Thanks for your feedback,

-- 
Aymeric.



-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to