Hello,
Django's development moved to GitHub 7 months ago, and it's a success!
No guidelines for pull requests were published, but usage patterns have
emerged. Here's what I've observed.
550 pull requests have been opened:
- 20% of them are still open. This figure is a slightly above reality
because pull requests sometimes stay open even after the corresponding problem
is fixed.
- 80% are closed. There's no easy way to tell if they were merged or
rejected.
Most open pull requests reference a Trac ticket.
Trac is used for almost all discussions. I believe there are two reasons for
this:
- every action on Trac is notified to more than 900 subscribers to the
django-updates mailing list;
- Trac is customized to match the community's and the core team's
workflows.
Pull requests are used as a replacement for patches uploaded to Trac, and as an
code review UI. The killer features here are line-by-line commenting, and to
some extent incremental review.
Pull requests that don't reference a Trac ticket tend to get lost into the
noise (507, 500, 497, 478, 451, 432, 421, 402, 393, 317, 272, 211, etc.). They
suffer from the lack of a triage process to ensure every PR gets looked at, and
categorization to help to locate PRs of interest. (By the way, these are the
main reasons why we didn't switch issue management to GitHub.) In the end,
trivial fixes such as typos generally get merged, more complex ones don't
without a discussion in a ticket.
Have you noticed other interesting patterns? What improvements to the
development processes would you suggest?
--
Aymeric.
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
