On Fri, Oct 12, 2012 at 6:36 AM, Yo-Yo Ma <[email protected]> wrote:
> +1 > > A lot of people are overriding ``save`` and not returning anything, but > this isn't going to hurt them (ideally, they should already be returning > the result of ``super(``, but nobody does). > > > On Friday, October 12, 2012 9:25:46 AM UTC-4, Chris Wilson wrote: >> >> Hi all, >> >> If the save() method returned the object itself, then we could chain it >> like this: >> >> old_status = Status(last_contact=None).**save() >> >> Instead of having to do this: >> >> old_status = Status(last_contact=None) >> old_status.save() >> >> It's a trivial one-line change to the Model class and I don't think it >> would break backwards compatibility, as I doubt that anyone is relying on >> the save() method returning None. Should I submit a patch? >> >> Cheers, Chris. >> -- >> Aptivate | http://www.aptivate.org | Phone: +44 1223 967 838 >> Future Business, Cam City FC, Milton Rd, Cambridge, CB4 1UY, UK >> >> Aptivate is a not-for-profit company registered in England and Wales >> with company number 04980791. >> >> -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/django-developers/-/WkAiV5BsEiEJ. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > This isn't going to happen. It violates a fundamental API design in Python: methods which mutate/have side effects return none, methods which return a new object... return a new object. This has a side effect, and doesn't construct a new object, ergo, it returns None. Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
