Hi Christopher,

The process from here:

 1) You convince someone else in the community to review your patch

 2) They look at the patch, and mark it Ready for Checkin; or, they
give you feedback, and you go back to step 1

 3) Someone on the core team commits the patch.

The "someone else" for step 1 doesn't need to be anyone in particular
-- it just needs to be "not you". Posting to the mailing list
generally ins't a great way to go about this, because you're really
looking for someone who is available "right now", and mail tends not
to elicit that kind of response; IRC is probably your best bet.

You can also beef up your chances of getting a review if you return
the favour -- find patches contributed by other people, and be their
"not you". Search Trac for a patch in an area of interest for you, and
validate that the patch applies, fixes the problem that it claims to
fix, that the fix makes sense, and that the patch has a test, has
documentation, and so on. If you've done this for other people, you
can get some good karma, and someone may be more inclined to return
the favour.

Yours,
Russ Magee %-)

On Wed, Aug 1, 2012 at 2:01 AM, Christopher Berner
<[email protected]> wrote:
> I submitted a pull request for an issue with management commands installed
> from setuptools packages (https://github.com/django/django/pull/240). Just
> wondering if anyone has feedback on the patch. Never contributed to Django
> before, so I'm not quite sure what the procedure is.
>
> Thanks!
> Christopher
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/django-developers/-/-R05yw7x4NcJ.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

  • Ticket 18685 Christopher Berner
    • Re: Ticket 18685 Russell Keith-Magee

Reply via email to