On Tue, Dec 6, 2011 at 2:33 AM, Vinay Sajip <[email protected]> wrote:
> > On Dec 6, 4:18 am, Ian Clelland <[email protected]> wrote: > > > If I replace line 25 with this block: > > > > resource_name = resource_string(app, pkg_name) > > if hasattr(resource_name, 'decode'): > > resource_name = resource_name.decode(settings.FILE_CHARSET) > > return (resource_name, 'egg:%s:%s' % (app, pkg_name)) > > > > then all (expected) tests pass. > > Thanks very much for this fix, I have applied it and tested in a venv, > and can confirm your findings. I have pushed this to BitBucket. I have > installed a PIL Python 3 port and bugs in that are causing 1 failure > and 1 error; everything else passes. > > Regards, > > Vinay Sajip > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > Without doing anything else, I installed pymysql, and made a few minimal modifications to use that module in the mysql backend, and fixed one Python3 incompatibility issue in db/backends/mysql/compiler.py. First initial test run indicates that there's still some work to do :) Ran 4429 tests in 18128.079s FAILED (failures=11, errors=375, skipped=114, expected failures=2, unexpected successes=1) (yeah, that's 18k seconds, just a bit over 5 hours, but mysql has never been fast on OS X; something about the way it rolls back the database between tests) My earlier tests took 439s, as a point of reference. Almost all of those errors appear to be of the same form: ====================================================================== ERROR: testApprovePost (regressiontests.comment_tests.tests.moderation_view_tests.ApproveViewTests) POSTing the delete view should mark the comment as removed ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/ian/Code/Frameworks/py3k_django/build/tests/regressiontests/comment_tests/tests/moderation_view_tests.py", line 142, in testApprovePost self.client.login(username="normaluser", password="normaluser") File "/Users/ian/Code/Frameworks/py3k_django/3k/django/test/client.py", line 514, in login login(request, user) File "/Users/ian/Code/Frameworks/py3k_django/3k/django/contrib/auth/__init__.py", line 73, in login request.session.cycle_key() File "/Users/ian/Code/Frameworks/py3k_django/3k/django/contrib/sessions/backends/base.py", line 253, in cycle_key self.delete(key) File "/Users/ian/Code/Frameworks/py3k_django/3k/django/contrib/sessions/backends/db.py", line 75, in delete Session.objects.get(session_key=session_key).delete() File "/Users/ian/Code/Frameworks/py3k_django/3k/django/db/models/base.py", line 583, in delete collector.delete() File "/Users/ian/Code/Frameworks/py3k_django/3k/django/db/models/deletion.py", line 61, in decorated func(self, *args, **kwargs) File "/Users/ian/Code/Frameworks/py3k_django/3k/django/db/models/deletion.py", line 228, in delete sender=model, instance=obj, using=self.using File "/Users/ian/Code/Frameworks/py3k_django/3k/django/dispatch/dispatcher.py", line 174, in send response = receiver(signal=self, sender=sender, **named) File "/Users/ian/Code/Frameworks/py3k_django/build/tests/modeltests/signals/tests.py", line 57, in pre_delete_test (instance, instance.id is None) AttributeError: 'Session' object has no attribute 'id' Now, on to tweaking MySQL and fixing a couple of those errors -- Regards, Ian Clelland <[email protected]> -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
