There's merit in both the responses. Since it's trivial to write your own transaction middleware, I would say the most important thing is to document that the middleware only affects your 'default' database. Then it's up to the developer to decide if they need anything further.
On Sun, Nov 13, 2011 at 7:05 PM, Yo-Yo Ma <[email protected]> wrote: > Before voting for more magic to the transaction middleware, I'd vote > to remove it altogether. Explicit is surely better than implicit in > this case. The admin already uses commit_on_success, etc. > > On Oct 18, 1:22 pm, David Winterbottom > <[email protected]> wrote: > > The current implementation of django.middleware.TransactionMiddleware > does > > not create a transaction for each database, only the default one > > defined by DEFAULT_DB_ALIAS > > -https://code.djangoproject.com/browser/django/trunk/django/db/utils.py. > > Shouldn't the middleware manage a transaction for each database defined > in > > the DATABASES setting? > > > > I discovered this while debugging some caching issues with the > johnnycache > > library, which saves cached querysets when committing. In my case, all > > requests to databases other than default were not being cached. > > > > Happy to supply a patch and tests if this is sensible. > > -- > > *Dr. David Winterbottom* > > Head of Programming > > > > Tangent Labs > > 84-86 Great Portland Street > > London W1W 7NR > > England, UK > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > > -- *Dr. David Winterbottom* Head of Programming Tangent Labs 84-86 Great Portland Street London W1W 7NR England, UK -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
