On 29/09/11 18:23, Alex Gaynor wrote:

> Your right, there should be an additional assert.  FWIW it's not even a
> time/memory tradeoff, it's just savings.  Type objects on every Python
> VM are some of the most expensive objects, and have various caches with
> them, allowing those caches to stay fresh, rather than creating a new
> one is an all around win.

OK, cool. I updated your patch on #14270, also adding some missing tests
for the ForeignKey related manager. It keeps some of my recent changes,
and reverts some, but this time there is rationale for having some
parameters as closures and not parameters stored on self.

Do you have any reason why this shouldn't be committed now?

Luke

-- 
I teleported home one night
With Ron and Sid and Meg,
Ron stole Meggie's heart away
And I got Sidney's leg
(THHGTTG)

Luke Plant || http://lukeplant.me.uk/

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to