On Monday, June 27, 2011 3:08:03 PM UTC-7, Jacob Kaplan-Moss wrote: > > I left some comments on the patch on the ticket. >
Excellent just saw those. I'll take a look. > > I'm using django-threadedcomments on a project, which has forward > > references in one of its test fixtures, so I'm reminded of this issue > > every time I run my project tests. I hate test errors! I'm hopeful the > > latest patch is sufficient to get this issue resolved. > > Does this patch work for you (I'm assuming so)? A "this works for me > in production" goes a huge way towards me feeling comfortable checking > things in. > Does it work in production is a hard question for me to answer, if I understood your question properly. In my projects, I really only touch the loaddata command when I'm running tests (I guess loading data via initial_data.json into a production DB sort of counts as running in production). I don't think anything in my proposed changes touches production code with possibly a few minor exceptions. I know that I can run the full Django test suite with MySQL in innodb and I do not get any fixture loading issues related to forward references. It'd be great if some others could test this patch out as well. In particular, I can't be sure how well ti works on older versions of MySQL. There's no crazy magic at work here but, well, you never know. If it works for others and we're all in agreement with the philosophical approach of the solution, I think it should be a fairly uncontroversial commit, since it's really primarily a fixture loading issue at its core. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/django-developers/-/NapNIk_SmOcJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
