Wow, this code is such a disaster.
I sent out a fix:
http://openvswitch.org/pipermail/dev/2015-October/061212.html
On Fri, Sep 11, 2015 at 01:58:43PM -0700, Ray Li wrote:
> Hi, here's another issue. If I create an empty group first without buckets,
> and then run insert-buckets with command_bucket_id=last, it will fail to
> add the bucket and somehow delete the empty group. it works if I ran
> insert-buckets with command_bucket_id=first though.
>
> On Thu, Sep 10, 2015 at 5:10 PM, Ray Li <rayli1...@gmail.com> wrote:
>
> > Hi, I've ran into another issue. I'm trying this on a new environment.
> > When I tried to add a group for the first time using OpenFlow15 with
> > bucket_id, I got an OFPBAC_BAD_LEN error. It worked though when I tried to
> > add a group using OpenFlow11 without bucket_id. Any idea what this means?
> >
> > ovs-ofctl add-group br1 group_id=0,type=all,bucket="actions=output:10" -O
> > OpenFlow11
> > (This works.)
> >
> > ovs-ofctl del-groups br1 -O OpenFlow11
> >
> > ovs-ofctl add-group br1
> > group_id=0,type=all,bucket="bucket_id=100,actions=output:10" -O OpenFlow15
> > OFPT_ERROR (OF1.5) (xid=0x2): OFPBAC_BAD_LEN
> > OFPT_GROUP_MOD (OF1.5) (xid=0x2):
> > ADD group_id=0,type=all,bucket=bucket_id:100,actions=output:10
> >
> > When I looked at the log files it shows:
> > 2015-09-11T00:08:59.622Z|00437|ofp_actions|WARN|bad action at offset 0
> > (OFPBAC_BAD_LEN):
> > 00000000 00 00 00 10 00 00 00 0a-
> > 2015-09-11T00:08:59.622Z|00438|connmgr|INFO|br0_vxlan<->unix: sending
> > OFPBAC_BAD_LEN error reply to OFPT_GROUP_MOD message
> >
> >
> >
> > Thanks
> >
> >
> >
> > On Thu, Sep 10, 2015 at 2:56 PM, Ben Pfaff <b...@nicira.com> wrote:
> >
> >> With the current behavior, insert-buckets doesn't automatically allocate
> >> non-overlapping bucket ids. This could be considered a bug in the
> >> documentation or in the code. It would be more user-friendly to
> >> consider a bug in the code and fix it in ovs-ofctl, but that's a bigger
> >> job than just fixing the crash as these commits do.
> >>
> >> On Thu, Sep 10, 2015 at 02:51:03PM -0700, Ray Li wrote:
> >> > According to ovs-ofctl's man page, if no bucket_id is specified it's
> >> > support to allocate one. Is that not being done? Or is that the bug
> >> itself?
> >> >
> >> > On Thu, Sep 10, 2015 at 1:21 PM, Ben Pfaff <b...@nicira.com> wrote:
> >> >
> >> > > On Thu, Sep 10, 2015 at 11:46:16AM -0700, Ray Li wrote:
> >> > > > Does OVS 2.4 support ovs-ofctl insert-buckets?
> >> > > >
> >> > > > I just upgraded to OVS 2.4.0, and here's what I tried to do:
> >> > > >
> >> > > > ovs-vsctl set bridge br0
> >> > > >
> >> > >
> >> protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13,OpenFlow14,OpenFlow15
> >> > > >
> >> > > > ovs-ofctl add-group br0
> >> group_id=0,type=all,bucket="actions=output:10" -O
> >> > > > OpenFlow11
> >> > > >
> >> > > > ovs-ofctl dump-groups br0 -O OpenFlow11
> >> > > > (which shows the groups table correctly with a single bucket)
> >> > > >
> >> > > > ovs-ofctl insert-buckets br0
> >> > > > group_id=0,command_bucket_id=last,bucket="actions=output:1" -O
> >> OpenFlow15
> >> > > >
> >> > > > ovs-ofctl dump-groups br0 -O OpenFlow11
> >> > > > (This then hangs indefinitely)
> >> > >
> >> > > It's a bug, thanks for reporting it.
> >> > >
> >> > > The underlying problem is that in both cases no bucket_id was
> >> specified,
> >> > > so it defaults to the same value in each case, and duplicate bucket
> >> IDs
> >> > > were not correctly handled. You can avoid the problem by specifying a
> >> > > different bucket_it in your "insert-buckets" command.
> >> > >
> >> > > I posted a fix. You can test it by applying the following two
> >> patches,
> >> > > in this order:
> >> > >
> >> http://openvswitch.org/pipermail/dev/2015-September/059865.html
> >> > >
> >> http://openvswitch.org/pipermail/dev/2015-September/059864.html
> >> > >
> >>
> >
> >
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss
