On Fri, Jul 24, 2015 at 02:45:33PM +0900, Minoru TAKAHASHI wrote:
> Hi,
>
> On 2015年07月22日 17:25, Minoru TAKAHASHI wrote:
> > Hi,
> >
> > Thank you for reply.
> >
> > On 2015年07月22日 00:19, Ben Pfaff wrote:
> >> On Tue, Jul 21, 2015 at 03:10:08PM +0900, Minoru TAKAHASHI wrote:
> >>>> they do not make the corresponding change to the decoder
> >>>
> >>> Should I fix this problem?
> >>> If so, please tell me that which source file should I fix.
> >>> (Sorry, I am new in implementation of OpenvSwitch.)
> >>
> >> I cannot apply anything to the repository that makes tests fail, so yes
> >> you should fix the decoder.
> >>
> >> The decode function is right next to the encode function.
>
> > ## ------------------------------ ##
> > ## openvswitch 2.4.90 test suite. ##
> > ## ------------------------------ ##
> >
> > 694: ofproto - del group (OpenFlow 1.5) FAILED (ofproto.at:350)
> > 696: ofproto - insert buckets FAILED (ofproto.at:424)
>
> I think that the following code is causing the above error.
>
> [lib/ofp-msgs.h]
> https://github.com/openvswitch/ovs/blob/master/lib/ofp-msgs.h#L336
>
> [tests/ofp-print.at]
> https://github.com/openvswitch/ovs/blob/master/tests/ofp-print.at#L2003
>
> After I fix these, the above error does not occur.
Did you run all the tests? I see three failures:
## ------------------------ ##
## Summary of the failures. ##
## ------------------------ ##
Failed tests:
openvswitch 2.4.90 test suite test groups:
NUM: FILE-NAME:LINE TEST-GROUP-NAME
KEYWORDS
695: ofproto.at:343 ofproto - del group (OpenFlow 1.5)
697: ofproto.at:418 ofproto - insert buckets
698: ofproto.at:476 ofproto - remove buckets
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss
