On Fri, May 23, 2014 at 05:22:18PM -0400, Lars Kellogg-Stedman wrote:
> This patch adds support for setting the persistent MAC address (on
> RHEL-derived systems) of an OVS bridge via the MACADDR setting in the
> interface configuration file.
> 
> Without this change, when an administrator provides MACADDR in the
> interface configuration file that address will be set in ifup-eth using
> the "ip link set" command.  While this appears to work, any operation
> that updates the OVS configuration will cause the MAC address to revert.
> 
> Persistent MAC addresses must be set using ovs-vsctl.

Seems reasonable.  Thanks!  Can we have a Signed-off-by line?  The
CONTRIBUTING file explains the format and the meaning of this line as
follows:

----------------------------------------------------------------------

Please sign off on the patch as a submitter, and be sure to have the
author(s) sign off for patches that you did not author.

Simply include your name and email address as the last line of the commit
message before any comments (and author too, if that is not you):

Signed-off-by: Author Name <author.name@email.address...>
Signed-off-by: Submitter Name <submitter.name@email.address...>

By doing this, you are agreeing to the Developer's Certificate of Origin
(see below for more details).

Developer's Certificate of Origin
---------------------------------

To help track the author of a patch as well as the submission chain,
and be clear that the developer has authority to submit a patch for
inclusion in openvswitch please sign off your work.  The sign off
certifies the following:

    Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the open source license
        indicated in the file; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

    (d) I understand and agree that this project and the contribution
        are public and that a record of the contribution (including all
        personal information I submit with it, including my sign-off) is
        maintained indefinitely and may be redistributed consistent with
        this project or the open source license(s) involved.
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss

Reply via email to