some minor suggestions inline:
On Mar 21, 2012, at 10:36 AM, Benoît Canet wrote: > > Hello, > > I am working to implement RFC 5517 (http://tools.ietf.org/html/rfc5517) in > Open vSwitch. > This mechanism enforce a few packets switching rules while reusing regular > 802.1Q vlan tagging. > > My first approach will be to reuse as much as possible of the existing vlan > code. > > However I will try hard to make the user interface changes the less > disruptive they could be. > > Before starting to code here is a draft of the command line interface > proposal. > > Could the developpers give their opinions on this interface ? > > Best regards > > Benoît > > 1) pvlan creation: > -------------- > > #create primary pvlan 66 > ovs-vsctl add-pvlan primary 66 > > #create isolated pvlan 68 > ovs-vsctl add-pvlan secondary 68 isolated > > #create community pvlan 70 > ovs-vsctl add-pvlan secondary 70 community > [ankur] we can loose the keyword "secondary" because it is implied in "isolated" or "community". that way the command to create any pvlan becomes same: ovs-vsctl add-pvlan primary 66 ovs-vsctl add-pvlan isolated 68 ovs-vsctl add-pvlan community 70 > # by default a secondary pvlan is isolated > # create isolated pvlan 72 > ovs-vsctl add-pvlan secondary 72 > > 2) pvlan pairing > ---------------- > > # pair the primary pvlan 66 with it's secondary > ovs-vsctl pair-pvlan 66 68 > ovs-vsctl pair-pvlan 66 70 > > 3) pvlan tagging > ---------------- > > # isolated port will communicate with tap4 > ovs-vsctl add-port br0 tap0 tag=68 > > # community port will communicate with tap3 and tap4 > ovs-vsctl add-port br0 tap1 tag=70 > > # isolated port will communicate with tap4 > ovs-vsctl add-port br0 tap2 tag=68 > > # community port will communicate with tap1 and tap4 > ovs-vsctl add-port br0 tap3 tag=70 > > # promiscuous port communicate with tap0, tap1, tap2, tap3 > ovs-vsctl add-port br0 tap4 tag=66 > > > 4) Make usage of the feature > ---------------------------- > > 5) unpair pvlans > ovs-vsctl unpair-pvlan 66 68 > ovs-vsctl unpair-pvlan 66 70 > > 6) teardown pvlans > ovs-vsctl del-pvlan 66 > ovs-vsctl del-pvlan 68 > ovs-vsctl del-pvlan 70 > ovs-vsctl del-pvlan 72 > > _______________________________________________ > discuss mailing list > discuss@openvswitch.org > http://openvswitch.org/mailman/listinfo/discuss
_______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss