I noticed that RPM build fails if ./configure decides that ovsdbmonitor
should be built:

1. ./configure
...
checking whether to build ovsdbmonitor... yes
...

2. rpmbuild -bb rhel/openvswitch.spec
...
error: Installed (but unpackaged) file(s) found:
   /usr/bin/ovsdbmonitor
   /usr/share/man/man1/ovsdbmonitor.1.gz
   /usr/share/openvswitch/ovsdbmonitor/OVEApp.py
   /usr/share/openvswitch/ovsdbmonitor/OVECommonWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVEConfig.py
   /usr/share/openvswitch/ovsdbmonitor/OVEConfigWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVEFetch.py
   /usr/share/openvswitch/ovsdbmonitor/OVEFlowWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVEHostWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVELogWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVELogger.py
   /usr/share/openvswitch/ovsdbmonitor/OVEMainWindow.py
   /usr/share/openvswitch/ovsdbmonitor/OVEStandard.py
   /usr/share/openvswitch/ovsdbmonitor/OVEUtil.py
   /usr/share/openvswitch/ovsdbmonitor/Ui_ConfigWindow.py
   /usr/share/openvswitch/ovsdbmonitor/Ui_FlowWindow.py
   /usr/share/openvswitch/ovsdbmonitor/Ui_HostWindow.py
   /usr/share/openvswitch/ovsdbmonitor/Ui_LogWindow.py
   /usr/share/openvswitch/ovsdbmonitor/Ui_MainWindow.py
   /usr/share/openvswitch/ovsdbmonitor/qt4reactor.py


3. While the build-deps in debian/control file pretty much suggests to
install all of the dependencies that lead ./configure to
BUILD_OVSDBMONITOR=yes

Build-Depends:
 debhelper (>= 5), autoconf (>= 2.64), automake (>= 1.10) | automake1.10,
 libssl-dev, pkg-config (>= 0.21), po-debconf, bzip2, openssl,
 python (>= 2.6.6-3), procps, python-qt4,
 python-zopeinterface, python-twisted-conch


   if (test $ovs_cv_py_PySide_QtCore = yes \
       || test $ovs_cv_py_PyQt4_QtCore = yes) \
      && test $ovs_cv_py_twisted_conch_ssh = yes \
      && test $ovs_cv_py_twisted_internet = yes \
      && test $ovs_cv_py_twisted_application = yes \
      && test $ovs_cv_py_json = yes \
      && test $ovs_cv_py_zope_interface = yes; then
     BUILD_OVSDBMONITOR=yes
   else
     BUILD_OVSDBMONITOR=no
   fi



This might get annoying if one wants to build both RPM and DEB packages on
the same Machine. What would be the preferred way to fix this?

   1. Modify RPM spec file so that ovsdbmonitor related files are removed
   right before RPM packaging?
   2. Modify RPM spec file so that those ovsdbmonitor files are included in
   RPM packaging (will there be any added value to distribute this tool also
   with RPMs)?
   3. Add flag to ./configure that allows to build ovsdbmonitor
   conditionally (this changes default build behavior)?


I would prefer to go with #1.

Thanks,
Ansis
_______________________________________________
discuss mailing list
discuss@openvswitch.org
http://openvswitch.org/mailman/listinfo/discuss

Reply via email to