On Wed, Mar 02, 2011 at 11:41:40PM -0800, Jesse Gross wrote: > On Wed, Mar 2, 2011 at 9:53 PM, Te-Yuan Huang <huan...@stanford.edu> wrote: > > However, for the process to work, we need to patch the original ovs codes. > > The patches are mostly related to some missing definitions in Android > > systems. > > All the patches can be found under cross_compile_patches/patches/ . > > We are wondering if those can be merged in with the current ovs codes. > > Please submit anything that you would like included in Open vSwitch to > the dev mailing list according to the style documented in > SubmittingPatches. > > In order for a patch to be included it needs to be generic - i.e. the > current use of #ifdef Android and manual modifications to generated > files doesn't work.
To expand on this, many of these can be made generic quite easily. For example, it seems that Android lacks SIG_ATOMIC_MAX. That's odd, but it could be generically fixed by adding #include "type-props.h" #ifndef SIG_ATOMIC_MAX #define SIG_ATOMIC_MAX TYPE_MAXIMUM(sig_atomic_t) #endif near the top of fatal-signal.c, which is the only file that uses SIG_ATOMIC_MAX. _______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org