On 24/10/2019 20:36, Müller, Marcus (CEL) wrote:
Hi Barry,
neat, haven't seen that one before, specifically :)
But I've seen a test fail:
https://github.com/gnuradio/gnuradio/issues/2678
Mageia is RPM-based, right? Never used it before, but could you point
me to the .SPEC file you're using to build that package?
Hunch: replace
utils.hide_bokeh_gui_options_if_not_installed(self.blocks['options'])
with
try:
utils.hide_bokeh_gui_options_if_not_installed(self.blocks['options'])
except KeyError: #this happens if there's no 'options' block
pass
and things should work.
I honestly think we could improve the
hide_bokeh_gui_options_if_not_installed to handle None arguments and
use .get('options') instead of ['options']. Willing to pick up on that?
Best regards,
Marcus
On Thu, 2019-10-24 at 19:03 +0100, Barry Jackson wrote:
[baz@jackodesktop ~]$ gnuradio-companion
Traceback (most recent call last):
File "/usr/bin/gnuradio-companion", line 102, in <module>
run_main()
File "/usr/bin/gnuradio-companion", line 95, in run_main
exit(main())
File "/usr/lib/python3.8/site-packages/gnuradio/grc/main.py", line
83, in main
platform.build_library()
File
"/usr/lib/python3.8/site-packages/gnuradio/grc/core/platform.py", line
197, in build_library
utils.hide_bokeh_gui_options_if_not_installed(self.blocks['options'])
File "/usr/lib64/python3.8/collections/__init__.py", line 891, in
__getitem__
return self.__missing__(key) # support subclasses that
define __missing__
File "/usr/lib64/python3.8/collections/__init__.py", line 883, in
__missing__
raise KeyError(key)
KeyError: 'options'
[baz@jackodesktop ~]$
I found this
https://www.mail-archive.com/discuss-gnuradio@gnu.org/msg69270.html
...which looked promising, but deleting .~.gnuradio changes nothing here.
I have just updated our (Mageia8) package tp py3/qt5 build and hit this
in testing prior to pushing to our dev branch repo.
Any ideas welcome :)
_______________________________________________
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
Hi Marcus,
No joy.
Using the change as you wrote it with the comment? on the line like:
except KeyError: #this happens if there's no 'options' block
...caused a build error which looked like it was during the docs build
at the start.
Knowing nothing about python I moved the comment? to the next line after
'pass' like:
pass #this happens if there's no 'options' block
(I saw this syntax in other similar structures in the same file)
.. that then built, but the error is the same:
[baz@jackodesktop ~]$ gnuradio-companion
Traceback (most recent call last):
File
"/usr/lib/python3.8/site-packages/gnuradio/grc/gui/Application.py", line
102, in do_activate
self.main_window = MainWindow(self, self.platform)
File
"/usr/lib/python3.8/site-packages/gnuradio/grc/gui/MainWindow.py", line
84, in __init__
generate_modes = platform.get_generate_options()
File
"/usr/lib/python3.8/site-packages/gnuradio/grc/core/platform.py", line
379, in get_generate_options
for param in self.block_classes['options'].parameters_data:
File "/usr/lib64/python3.8/collections/__init__.py", line 891, in
__getitem__
return self.__missing__(key) # support subclasses that
define __missing__
File "/usr/lib64/python3.8/collections/__init__.py", line 883, in
__missing__
raise KeyError(key)
KeyError: 'options'
The build errors with the patch as you had it can be seen in this build
fail:
http://mtf.duckdns.org/pub/linux/barjac/distrib/cauldron/x86_64/log/gnuradio-3.8.0.0-1.3.mga8_bcj.src.rpm/build.0.20191024221952.log
OK I'm off to bed!
Cheers,
Barry
