On Wed, Sep 2, 2015 at 8:52 PM, Jeff Long <willco...@gmail.com> wrote:
> Hi Jeon, > > Here's a long-winded answer. You're correct, but I wanted to make sure the > terminology was clear. > > Tag offsets in add_item_tag() are absolute, relative to the beginning of > the sample stream, not relative to input or output buffers. But it's > probably safer to think in terms of absolute number of items written to > each output buffer. For rate-changing blocks, the input/output offsets will > be different. In add_item_tag(), you specify an output port, so that's > another reason to think in terms of output samples. > > Yes, get_items_in_*() fetch tags from a stream on an input port. Again, > offsets are absolute, so input buffers are not really relevant. But, it > makes sense to search for tags related to the samples in the input buffer. > The easiest function to use is get_tags_in_window(), which simply adds > nitems_read[port] to the provided offsets. The absolute offset is available > as a field in each tag. The get_tags_in_range() function does the same > thing, just without adding nitems_read[port]. > > You could search for tags whose offsets are earlier/later than the offsets > of the samples in an input buffer. However, older tags are likely to have > been deleted, and future tags (I think this can actually happen) would be > really confusing. > > - Jeff > > > On 09/02/2015 01:50 PM, Michael Dickens wrote: > >> Hi Jeon - It is quite possible that some presentations contain minor >> typos or even errors. Research/development and presentation of it is >> imperfect at best. Discussion such as this is the right thing to do! If >> anyone catches minor typos or errors in any GRCon15 presentation (or, >> for that matter, a paper relevant to SDR / GR / GRCon), please ping this >> list and the researcher/developer/presenter so that the info is >> searchable and might even be fixed in some future paper/presentation. >> All of the above said, hopefully Tom is reading through these emails & >> can respond.. Thanks for getting the discussion started! - MLD >> On Tue, Sep 1, 2015, at 09:40 AM, Jeon wrote: >> >>> In a presentation 'Stream Tags, PDUs, and Message Passing' by Tom >>> Rondeau, it seems some minor typos in pp. 14-18 >>> Assuming my knowledge is correct, add_item_tag() should use offset of >>> output buffer, not input buffer. And get_tags_in_*() use offset of >>> input buffer. >>> 1. Page 16 is referring nitems_read() for add_item_tag(). >>> 2. add_item_tag() slides contain figures of input buffer and >>> get_items_in_*() slides contain figures of output buffer. >>> Since I've not attended GRCon15 and judge a presentation without any >>> speech nor context, I might just point wrong thing. >>> >> Yep, that was an error. I've just updated the presentation on the site with the fixes. Thanks for pointing that out. I've just been too busy until today to get around to fixing it. Tom
_______________________________________________ Discuss-gnuradio mailing list Discuss-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
