Hi Tom,
I'm afraid my patch broke something :( gr-osmosdr and probably some
other OOT projects that were using GnuradioConfig but without using
the _ALL_ variable but using the individual ones.
Turns out that after the patch, GNURADIO_XXX_LIBRARIES is no longer
directly build from find_library, but from a custom foreach loop (to
build up the proper list)
But that also mean that it's scope is not restricted to the function
and is not global and so not available elsewhere.
The attached patch fixes that by re-declaring the variable in the parent scope.
This fixes the gr-osmosdr build for me.
@Martin : could you give it a shot to check it fixes it for you too ?
Cheers,
Sylvain
On Mon, Nov 11, 2013 at 8:40 PM, Tom Rondeau <t...@trondeau.com> wrote:
> On Sun, Nov 10, 2013 at 11:56 AM, Sylvain Munaut <246...@gmail.com> wrote:
>>> I'm having a couple of issues when trying to switch from
>>> FindGnuradioRuntime to GnuradioConfig
>>
>> Attached a patch that deals with issue 1 & 3. Issue 2 doesn't seem to
>> be an issue since ALL_LIBRARIES has absolute path in it.
>>
>> Cheers,
>>
>> Sylvain
>
>
> Thanks, Sylvain. I was actually working on a tutorial for gnuradio.org
> to describe the use of GnuradioConfig when I noticed the exact same
> issue with the _ALL_ variables. Your patch did the trick and has been
> pushed.
>
> Tom
diff --git a/cmake/Modules/GnuradioConfig.cmake
b/cmake/Modules/GnuradioConfig.cmake
index c162d09..a81211f 100644
--- a/cmake/Modules/GnuradioConfig.cmake
+++ b/cmake/Modules/GnuradioConfig.cmake
@@ -87,6 +87,8 @@ function(GR_MODULE EXTVAR PCNAME INCFILE LIBFILE)
list(APPEND ${LIBVAR_NAME} ${${LIBVAR_NAME}_${libname}})
endforeach(libname)
+ set(${LIBVAR_NAME} ${${LIBVAR_NAME}} PARENT_SCOPE)
+
# show results
message(" * INCLUDES=${GNURADIO_${EXTVAR}_INCLUDE_DIRS}")
message(" * LIBS=${GNURADIO_${EXTVAR}_LIBRARIES}")
_______________________________________________
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
