tqchen commented on code in PR #20362:
URL: https://github.com/apache/tvm/pull/20362#discussion_r4025950990
##########
src/backend/cuda/runtime/cuda_device_api.cc:
##########
@@ -316,6 +317,9 @@ TVM_FFI_STATIC_INIT_BLOCK() {
.def_packed("device_api.cuda",
[](ffi::PackedArgs args, ffi::Any* rv) {
DeviceAPI* ptr = CUDADeviceAPI::Global();
+ // Initialize the pool before contrib thread-local objects
finish construction,
+ // so they return retained workspaces before the pool is
destroyed.
Review Comment:
in this case, the fix should not be in here, but instead should be on the
Conv2d entry side likely, workspace pool alloc there should not use workspace
pool but use allocspace/freespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
