Seven-Streams commented on code in PR #792: URL: https://github.com/apache/tvm-ffi/pull/792#discussion_r4011281823
########## docs/guides/rust_lang_guide.md: ########## @@ -477,10 +477,13 @@ container's children are mapped forces the non-in-place path. Reflected objects must provide `__ffi_shallow_copy__`; the copy is validated before fields are mapped and discarded if no structural field changes. -Within one `structural_map` call, object identities whose structural-hash kind -is `FreeVar` or `DAGNode` are mapped once. The engine caches the complete final -result (including callback replacement and child mapping), reuses that exact -mapped identity at later occurrences, and does not invoke the callback again. +Within one `structural_map` call, callbacks run at every occurrence, including +repeated `FreeVar` and `DAGNode` identities. Default reflected recursion manages +identity substitutions; callback replacements are not cached. A variable use +without a recorded substitution retains the original without visiting fields. +Unchanged simple definitions need no entry; pattern definitions and DAG nodes +can cache `Unchanged` to skip repeated descent. Registered hooks manage their +own remapping. Review Comment: I think the doc can be simplified. We do not need to mention `FreeVar` and `DAGNode` again since we have aligned them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
