professor-moody commented on PR #19997: URL: https://github.com/apache/tvm/pull/19997#issuecomment-4961601624
Thanks for the review. Addressed both points: added the null check on the shard buffer, and an `nbytes % 2 == 0` guard on the `f32-to-bf16` path — the latter also prevents the odd-`nbytes` buffer overwrite you flagged, since `buffer(nbytes / 2)` would otherwise be one byte short of the `memcpy`. Both fold into the same tensor-cache bounds hardening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
