gemini-code-assist[bot] commented on code in PR #19990:
URL: https://github.com/apache/tvm/pull/19990#discussion_r3567108966
##########
pyproject.toml:
##########
@@ -91,7 +91,7 @@ dev = [{ include-group = "test" }, { include-group = "lint" }]
[tool.scikit-build]
cmake.build-type = "Release"
wheel.py-api = "py3"
-build-dir = "build/{wheel_tag}"
+build-dir = "build"
Review Comment:
Changing `build-dir` to `"build"` can conflict with manual C++ builds.
Developers typically build TVM from source by creating a `build` directory at
the root and running `cmake ..` with custom configurations (e.g., enabling
CUDA, LLVM, etc.).
If they then run `pip install -e .` or `pip install .`, `scikit-build-core`
will reconfigure the same `build` directory using the default settings in
`pyproject.toml` (which has `USE_CUDA = "OFF"`), overwriting the developer's
custom CMake cache and build artifacts.
Consider using a dedicated subdirectory like `build/wheel` to isolate Python
wheel builds from manual C++ builds, and update `tvm.libinfo` if necessary to
search this path.
```suggestion
build-dir = "build/wheel"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
