gemini-code-assist[bot] commented on code in PR #19983: URL: https://github.com/apache/tvm/pull/19983#discussion_r3563219218
########## .github/actions/detect-env-vars/action.yml: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Detect Environment Variables +description: Detects environment variables such as CPU count and sets them as outputs. +runs: + using: "composite" + steps: + - name: Run Python to detect environment variables + shell: python + id: detect + run: | + import multiprocessing, os + + output_file = open(os.environ.get("GITHUB_OUTPUT"), "a") + + def write_env_var(name, value): + output_file.write(f"{name}={value}\n") + print(f"Detected environment variable: {name}={value}") + + write_env_var("cpu_count", multiprocessing.cpu_count()) Review Comment:  Opening a file without a `with` statement can lead to resource leaks if the file is not properly closed. Additionally, `multiprocessing.cpu_count()` can raise a `NotImplementedError` on certain platforms, and `os.environ.get("GITHUB_OUTPUT")` can return `None` if the environment variable is not set, leading to a `TypeError` when opening the file. Using a `with` statement ensures the file is closed properly, and using `os.cpu_count()` with a fallback to `1` provides a safer and more robust implementation. ```yaml import os def write_env_var(name, value): github_output = os.environ.get("GITHUB_OUTPUT") if github_output: with open(github_output, "a") as f: f.write(f"{name}={value}\n") print(f"Detected environment variable: {name}={value}") write_env_var("cpu_count", os.cpu_count() or 1) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
