hiSandog commented on PR #19978: URL: https://github.com/apache/tvm/pull/19978#issuecomment-4942238721
Normalizing the modular-set base by `gcd(coeff, modulus)` rather than the full modulus matches the information carried by the congruence class. A valuable edge case would combine a negative base with a nontrivial gcd, since language-level remainder conventions can otherwise hide sign-related mistakes in normalization. Including both `Mod` and `FloorMod` variants of that case would make the intended behavior explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
