hamzaqureshi5 opened a new pull request, #19968:
URL: https://github.com/apache/tvm/pull/19968

   The ONNX importer's Gather converter asserted that indices must be a 
constant whenever the data operand is a ShapeExpr, raising "Only constant 
indices supported for shape gather." for any runtime-computed index. Detection 
post-processing graphs such as FasterRCNN feed a dynamic index into a Gather 
whose data comes from a Shape node, so import failed before compilation could 
start.
   
   Keep the fast path for a single constant index, which resolves one dimension 
to a PrimValue and preserves shape-specialized handling downstream. Any other 
index (dynamic, or a constant selecting multiple dimensions) materializes the 
shape as an int64 tensor via shape_to_tensor and gathers from it at runtime, 
reusing the existing negative-index normalization.
   
   Adds a regression test that gathers a dimension out of a Shape result using 
a non-constant index, covering positive and negative indices, and checks it 
against onnxruntime.
   
   Fixes part of #19965.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to