tqchen commented on code in PR #630:
URL: https://github.com/apache/tvm-ffi/pull/630#discussion_r3523082402
##########
include/tvm/ffi/optional.h:
##########
@@ -476,6 +477,22 @@ struct TypeTraits<Optional<T>> : public TypeTraitsBase {
return R"({"type":"Optional","args":[)" + details::TypeSchema<T>::v() +
"]}";
}
};
+
+/// \cond Doxygen_Suppress
+// The Rust binding (rust/tvm-ffi/src/option.rs) mirrors Optional<T> in place
as
+// `{ T value; bool engaged; }`; fail early if a toolchain's std::optional
deviates from that.
+namespace details {
Review Comment:
move static assert into test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
