tqchen commented on PR #19916: URL: https://github.com/apache/tvm/pull/19916#issuecomment-4846035746
Addressed the latest owner cleanup feedback in `29b344a86c`: visible-path selection remains member state on `DocPrinter` and is now consumed directly by `DocToPythonScript`; the TLS handoff, `RenderPythonScriptWithVisiblePaths`, and `visible_path.h` are removed. The printer no longer generically trims trailing whitespace: it removes only its known terminal newline, with an exact regression confirming other trailing whitespace is preserved. Direct-printer underline expectations now cover the default-on access-path output exactly. The rebuilt full TVMScript suite passed (781 passed, 1 skipped, 1 expected failure), the dedicated structural/pass-error set passed 8/8, and pre-commit plus diff checks passed. Public and private staging heads are identical at this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
