mvanhorn commented on PR #19816: URL: https://github.com/apache/tvm/pull/19816#issuecomment-4738398646
Thanks for the careful review! Both addressed in 9518915a: 1. The frontend now raises `NotImplementedError` for 5D `mode="cubic"` (4D bicubic is still fine via TOPI's 2D path), so an unsupported volumetric-cubic model fails fast at import with a clear message instead of dying later at legalization. Added a regression test. 2. Fixed the 4D shape-inference mismatch in `InferStructInfoGridSample`: the 4D branch now reads the permuted spatial dims (`values[2]`/`values[3]`) to match the frontend's `[N, 2, H_out, W_out]` permutation, mirroring the 5D branch. Added a non-square 4D test (`[1, 3, 5, 2]` -> `[1, 3, 3, 5]`) that catches the old `values[1]`/`values[2]` bug. I couldn't run pytest locally (no TVM build here), so I'm relying on CI for the compiled checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
