cbalint13 opened a new pull request, #19778:
URL: https://github.com/apache/tvm/pull/19778
This fixes several race conditions and enhances printing infos:
* Protect against race condition if ```list``` or ```remove``` on
nonexistent filepath is attempted
* ```ListDir``` returns gracefully when folder empty without exception
thrhowed
* Make sure ```TVM_FFI_THROW``` also ```_exit()```, not blocking the
child (until timeout)
* Enhance printed info during ```tvm_rpc``` with concise & trackable
status updates
This enhanches significantly the speed of remote tuning, previously stalled
due to race conditions.
---
#### Before
* Child worker never exited on its own, it was always killed (on timeout):
```
[02:52:48] {..}/rpc_server.cc:310: Connection success 192.168.1.2:39460
[02:52:48] {..}/rpc_env.cc:149: Load module from
/tmp//.cache/tvm_tmp_mod.tar.so ...
[02:52:50] {..}/rpc_server.cc:208: Child pid=3727459 killed (timeout = 2),
Process status = 15
[02:52:50] {..}/rpc_server.cc:239: Socket Connection Closed
```
#### After
* Based on child condition and exit now we have:
```
[09:43:54] {..}/rpc_server.cc:312: New session from 192.168.1.2:37304
[09:43:54] {..}/rpc_env.cc:123: Load module from
/tmp//.cache/tvm_tmp_mod.tar.so ...
[09:44:03] {..}/rpc_server.cc:334: Finish serving 192.168.1.2:37304
[09:44:03] {..}/rpc_server.cc:212: Child pid=409590 finished, status = 0
[09:44:03] {..}/rpc_server.cc:241: End session with 192.168.1.2:37304
```
```
[09:46:25] {..}/rpc_server.cc:312: New session from 192.168.1.2:58152
[09:46:25] {..}/rpc_env.cc:123: Load module from
/tmp//.cache/tvm_tmp_mod.tar.so ...
[09:46:26] {..}/rpc_server.cc:208: Child pid=414284 killed (timeout = 1
sec), status = 15
[09:46:26] {..}/rpc_server.cc:241: End session with 192.168.1.2:58152
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
