gemini-code-assist[bot] commented on code in PR #19746:
URL: https://github.com/apache/tvm/pull/19746#discussion_r3401596860
##########
tests/python/support/test_popen_pool.py:
##########
@@ -90,7 +90,7 @@ def test_popen_pool_executor():
import tvm
- pool = PopenPoolExecutor(max_workers=2, timeout=0.01)
+ pool = PopenPoolExecutor(max_workers=2, timeout=0.015)
Review Comment:
While increasing the timeout from 10ms to 15ms reduces the likelihood of a
race condition, 15ms is still extremely short and highly susceptible to
flakiness in busy CI environments where CPU scheduling delays can easily exceed
15ms. Since `value1` is submitted with a 100-second delay (`identity_after, 1,
100`), we can safely increase the pool timeout to a more robust value like
`0.1` (100ms) or `0.2` (200ms). This will make the test significantly more
stable on loaded CI runners while keeping the test execution time negligible.
```suggestion
pool = PopenPoolExecutor(max_workers=2, timeout=0.1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
