ksgr5566 commented on code in PR #18823: URL: https://github.com/apache/tvm/pull/18823#discussion_r3033408551
########## web/emcc/webgpu_runtime.cc: ########## @@ -40,6 +40,8 @@ #include "../../src/runtime/metadata.h" #include "../../src/runtime/workspace_pool.h" #include "../../src/support/bytes_io.h" +#include "3rdparty/tvm-ffi/src/ffi/extra/json_parser.cc" +#include "3rdparty/tvm-ffi/src/ffi/extra/json_writer.cc" Review Comment: Without this I encountered a failure at at WebGPU runtime in the browser, when loading the compiled model WASM. Upon further digging I found that the break came from the refactor that replaced `dmlc::JSONWriter` with `tvm::ffi::json::Stringify` in `webgpu_runtime.cc`. dmlc was header-only, but `tvm::ffi::json` splits declaration and implementation, so in the WASM unity build the `Stringify` implementation was not compiled into the WebGPU runtime unit and showed up as a missing runtime symbol. These two includes are there to pull the JSON implementation into the same WASM compilation unit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
