gnguralnick commented on PR #18961: URL: https://github.com/apache/tvm/pull/18961#issuecomment-4179441776
Addressed: 1. `maxPodArgs` naming - makes sense, renamed to `numPodSlots` to better convey that it's a count of uniform buffer slots, not a maximum 2. `packDimX` comment - agreed, restored an explainer comment 3. `podArgIndices.length === 0` edge case - my updated calculation is equivalent to the original one here, so there's no new risk introduced. The 4-byte uniform buffer would've been the behavior before as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
