gemini-code-assist[bot] commented on code in PR #18966: URL: https://github.com/apache/tvm/pull/18966#discussion_r3027626582
########## python/tvm/relax/transform/transform.py: ########## @@ -1043,7 +1043,7 @@ def LiftTransformParams(shared_transform: bool | list[str] = False) -> tvm.ir.tr def BundleModelParams(param_tuple_name: str | None = None) -> tvm.ir.transform.Pass: - """Bundle several model parameters into a single tuple paramters + """Bundle several model parameters into a single tuple parameters Review Comment:  The phrase 'single tuple parameters' is grammatically incorrect and redundant. It should be 'single parameter tuple' or simply 'single tuple' to correctly describe the bundling of multiple parameters into one. ```suggestion """Bundle several model parameters into a single parameter tuple ``` ########## tests/python/contrib/test_hexagon/README_RPC.md: ########## @@ -29,9 +29,9 @@ The communication between x86 and Android is done via the standard TVM RPC proto A packet between Android and Hexagon is proxy-ed by the Hexagon FastRPC mechanism. FastRPC depends on the auto-generated implementations of client- and server- side API. During the build time, the Android side API (”stub”) and the Hexagon side API (”skel”) is generated from `src/runtime/hexagon/rpc/hexagon_rpc.idl` (see `cmake/modules/Hexagon.cmake`). -When TVM’s RPC server on Android, `tvm_rpc_android_server`, invokes `hexagon_rpc_send(...)`, it actually calls into the same-name function defined in the stub with the exact same arguments (which includes the URI for the `*skel.so` library to use on Hexagon, which in our case is `libhexagon_rpc_skel.so`). Similarly, on the Hexagon side, `hexagon_rpc_send(...)` call is first intercepted by the “skel” API, which in tern calls the actual implementation defined in `src/runtime/hexagon/rpc/rpc_server.cc`. +When TVM’s RPC server on Android, `tvm_rpc_android_server`, invokes `hexagon_rpc_send(...)`, it actually calls into the same-name function defined in the stub with the exact same arguments (which includes the URI for the `*skel.so` library to use on Hexagon, which in our case is `libhexagon_rpc_skel.so`). Similarly, on the Hexagon side, `hexagon_rpc_send(...)` call is first intercepted by the “skel” API, which in turn calls the actual implementation defined in `src/runtime/hexagon/rpc/rpc_server.cc`. Review Comment:  The file path `src/runtime/hexagon/rpc/rpc_server.cc` is incorrect. Based on the repository structure, the file is located at `src/runtime/hexagon/rpc/hexagon/rpc_server.cc`. This should be updated to ensure the documentation is accurate and consistent with other references in the file (e.g., line 119). ```suggestion When TVM’s RPC server on Android, `tvm_rpc_android_server`, invokes `hexagon_rpc_send(...)`, it actually calls into the same-name function defined in the stub with the exact same arguments (which includes the URI for the `*skel.so` library to use on Hexagon, which in our case is `libhexagon_rpc_skel.so`). Similarly, on the Hexagon side, `hexagon_rpc_send(...)` call is first intercepted by the “skel” API, which in turn calls the actual implementation defined in `src/runtime/hexagon/rpc/hexagon/rpc_server.cc`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
