gemini-code-assist[bot] commented on code in PR #18964:
URL: https://github.com/apache/tvm/pull/18964#discussion_r3021878530
##########
web/package-lock.json:
##########
@@ -1,12 +1,12 @@
{
"name": "tvmjs",
- "version": "0.24.0-dev2",
+ "version": "0.25.dev0",
Review Comment:
This version string should be updated to `0.25.0-dev0` to match the
corrected version in `package.json` and adhere to the npm SemVer requirements.
```suggestion
"version": "0.25.0-dev0",
```
##########
web/package.json:
##########
@@ -3,7 +3,7 @@
"description": "TVM WASM/WebGPU runtime for JS/TS",
"license": "Apache-2.0",
"homepage": "https://github.com/apache/tvm/tree/main/web";,
- "version": "0.24.0-dev2",
+ "version": "0.25.dev0",
Review Comment:
The version string for npm packages must follow the SemVer format. The
current value `0.25.dev0` is invalid for npm and inconsistent with the
project's versioning convention defined in `version.py` (lines 198-199), which
transforms development versions into the `X.Y.0-devN` format. It should be
`0.25.0-dev0`. It is recommended to run `python version.py` to ensure all
version strings are correctly synchronized across the repository.
```suggestion
"version": "0.25.0-dev0",
```
##########
web/package-lock.json:
##########
@@ -1,12 +1,12 @@
{
"name": "tvmjs",
- "version": "0.24.0-dev2",
+ "version": "0.25.dev0",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "tvmjs",
- "version": "0.24.0-dev2",
+ "version": "0.25.dev0",
Review Comment:
This version string should be updated to `0.25.0-dev0` to match the
corrected version in `package.json` and adhere to the npm SemVer requirements.
```suggestion
"version": "0.25.0-dev0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
