mshr-h opened a new pull request, #18883: URL: https://github.com/apache/tvm/pull/18883
Fix #18882 `TargetNode::ToConfig()` exports all target attrs, including derived `feature.*` fields set by target canonicalizers. However, `TargetInternal::FromConfig()` rejects these keys during schema validation because they are not declared in the target kind schema. This breaks round-tripping exported configs through `Target(config)`. This PR strips `feature.*` keys from the config before `ConfigSchema::Resolve`, then merges them back afterward. Canonicalizer output is authoritative — if the canonicalizer re-emits a `feature.*` key, it overwrites the preserved value. Unknown non-`feature.*` keys continue to fail validation as before. Changes: - src/target/target.cc: Extract and re-merge `feature.*` keys around schema resolution in `FromConfig()` - tests/cpp/target_test.cc: Add tests for single-target round-trip, nested-host round-trip, and continued rejection of unknown non-feature keys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
