gemini-code-assist[bot] commented on code in PR #18875: URL: https://github.com/apache/tvm/pull/18875#discussion_r2887797628
########## docker/README.md: ########## @@ -87,16 +87,16 @@ produces the image ``tvm.ci_cpu`` that is displayed in the list of docker images using the command ``docker images``. To run an interactive terminal, execute: ````bash -./docker/bash.sh tvm.ci_cpu +./docker/bash.sh Dockerfile.ci_cpu Review Comment:  The image name `Dockerfile.ci_cpu` seems incorrect. The `bash.sh` script expects a Docker image name or a shortcut (like `ci_cpu`), not a Dockerfile path. Using `Dockerfile.ci_cpu` will likely cause the command to fail. For consistency with the next example and to ensure the command works as intended, this should probably be `ci_cpu`. ```suggestion ./docker/bash.sh ci_cpu ``` ########## docker/README.md: ########## @@ -87,16 +87,16 @@ produces the image ``tvm.ci_cpu`` that is displayed in the list of docker images using the command ``docker images``. To run an interactive terminal, execute: ````bash -./docker/bash.sh tvm.ci_cpu +./docker/bash.sh Dockerfile.ci_cpu ```` or ````bash -./docker/bash.sh tvm.ci_cpu echo hello tvm world +./docker/bash.sh ci_cpu echo hello tvm world ```` -the same applies to the other images (``./docker/Dockerfile.*```). +the same applies to the other images (```./docker/Dockerfile.*```). Review Comment:  The use of triple backticks for inline code is inconsistent with the rest of the document, which uses double backticks (e.g., ` ``tvm.ci_cpu`` ` on line 86). To maintain a consistent style, please use double backticks here as well. ```suggestion the same applies to the other images (``./docker/Dockerfile.*``). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
