mshr-h commented on code in PR #18632:
URL: https://github.com/apache/tvm/pull/18632#discussion_r2658921061


##########
python/tvm/relax/analysis/analysis.py:
##########
@@ -312,6 +312,26 @@ def all_vars(expr: Expr) -> List[Var]:
     return _ffi_api.all_vars(expr)
 
 
+def get_used_vars(expr: Expr) -> List[Var]:

Review Comment:
   nit: the func name might be better to be `used_vars()` to be consistent with 
`all_vars()` and `free_vars()`? cc @tlopex @cbalint13 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to