gemini-code-assist[bot] commented on code in PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378#discussion_r2657035818
##########
include/tvm/ffi/reflection/overload.h:
##########
@@ -145,7 +145,8 @@ struct TypedOverload : OverloadBase {
private:
template <std::size_t I>
- void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args,
int32_t num_args) {
+ void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args,
+ [[maybe_unused]] int32_t num_args) {
Review Comment:
While `[[maybe_unused]]` correctly suppresses the compiler warning, a
cleaner solution would be to remove the `num_args` parameter from
`GetMismatchMessageAux` entirely, as it is not used. This would improve code
clarity by removing the unneeded parameter and would require updating its call
sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
