Sven Neumann wrote:
Hi,
Hi,
On Tue, 2009-07-21 at 00:40 +0300, Ville Syrjälä wrote:
Is there a particular reason for this check? Would other drivers break
if I removed this line of code? How can I properly enable drivers that
don't use any MMIO ?
I think it can be removed without issues, but Ville might know more, AFAIR,
he has added the code.
I don't think I touched that bit. I only added the matrox dualhead
hack.
git blame gives me the following. Unfortunately the changelog doesn't
provide useful information about why it was changed :(
commit fbf15dbbba6398850b54112ace094d019351a44a
Author: Claudio Ciccani <k...@directfb.org>
Date: Fri Aug 12 11:00:56 2005 +0000
system_get_accelerator() returns -1 if mmio memory lenght is 0.
I've checked the changes Claudio was working on at the time he did that
change. Looks like he was working on the nvidia and the r200 drivers.
But I still can't figure out what this change is good for.
What are our options now? I'd like to get rid of this questionable
check. But of course I could also introduce yet another hack in
system_get_accelerator() and special case the PXA3XX hardware. Any
opinions?
I think he did that to avoid usage of the accelerated driver when the
MMIO region is not exported.
The check for the mmio length should move into the driver.
--
Best regards,
Denis Oliver Kropp
.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/ |
'------------------------------------------'
_______________________________________________
directfb-dev mailing list
directfb-dev@directfb.org
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
