On Mon, Jan 12, 2009 at 07:03:05PM +0100, Niels Roest wrote:
> I understand that in some input device cases, a keymap will not present.
> Using an external utility doesn't seem very portable to me. I mean, you 
> would want DirectFB to solve this in the library (or the keyboard input 
> module), rather than linking an external app against DirectFB. See it as 
> extended configuration..
> I agree that loading it from a file may not be the best way, but I would 
> rather solve it by changing it to a more 'portable' API.
> What do you think?

Hmm. Yeah, you're right. I didn't think about that scenario. But the
current code doesn't really solve that issue either since AFAICS there's
no way to load the keymap via directfbrc, but that should be simple to
fix. So it seems that it is best to keep the keymap parsing code in the
library instead of moving it.

However I think dfbinput should still should grow keymap loading support
(it already has the -r switch to reload the map from the kernel). It would
also be beneficial if dfbinput could dump the keymap in the same format
that the parser uses.

> Ville Syrjälä wrote:
> > On Mon, Jan 12, 2009 at 06:17:18PM +0100, Niels Roest wrote:
> >   
> >> Hiya Nicholas,
> >> thanks for the patch!
> >> no fixed why of sending, so either is ok.
> >>
> >> That was a silly mistake. Put your patch in the 1.3.x branch.
> >>
> >> Not sure what to do with the keymap tho.. Maybe in directfb-examples.. 
> >> But then maybe df_input needs to be extended with an option for reading 
> >> keymaps or something..
> >>     
> >
> > I recommend adding keymap loading support to dfbinput which is part of
> > DirectFB.
> >
> > Actually I would even suggest moving the keymap parsing code completely
> > into dfbinput. Having it as part of the DirectFB ABI doesn't seem quite
> > right to me.
> >
> >   

> 
> Ville Syrjälä wrote:
> > On Mon, Jan 12, 2009 at 06:17:18PM +0100, Niels Roest wrote:
> >   
> >> Hiya Nicholas,
> >> thanks for the patch!
> >> no fixed why of sending, so either is ok.
> >>
> >> That was a silly mistake. Put your patch in the 1.3.x branch.
> >>
> >> Not sure what to do with the keymap tho.. Maybe in directfb-examples.. 
> >> But then maybe df_input needs to be extended with an option for reading 
> >> keymaps or something..
> >>     
> >
> > I recommend adding keymap loading support to dfbinput which is part of
> > DirectFB.
> >
> > Actually I would even suggest moving the keymap parsing code completely
> > into dfbinput. Having it as part of the DirectFB ABI doesn't seem quite
> > right to me.
> >
> >   
> 
> 
> -- 
> 
> .------------------------------------------.
> | DirectFB - Hardware accelerated graphics |
> | http://www.directfb.org/                 |
> "------------------------------------------" 
> 
> _______________________________________________
> directfb-dev mailing list
> directfb-dev@directfb.org
> http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

-- 
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
_______________________________________________
directfb-dev mailing list
directfb-dev@directfb.org
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to