Denis Oliver Kropp wrote: > Denis Oliver Kropp wrote: >> Phil Endecott wrote: >>> Denis Oliver Kropp wrote: >>>> Phil Endecott wrote: >>>>> http://chezphil.org/tmp/dfb_rotation_1.patch >>>> Many thanks. I applied it to 1.1.x (only few conflicts). >>> Excellent. I have found one further thing that needed changing: >>> >>> --- DirectFB-1.0.0.orig/src/core/gfxcard.c 2007-03-03 >>> 20:23:01.000000000 +0000 >>> +++ DirectFB-1.0.0/src/core/gfxcard.c 2007-10-13 19:49:21.000000000 >>> +0100 >>> @@ -1582,9 +1582,12 @@ >>> D_ASSERT( bytes > 0 ); >>> D_ASSERT( font != NULL ); >>> >>> - /* simple prechecks */ >>> - if (x > state->clip.x2 || y > state->clip.y2 || >>> - y + font->ascender - font->descender <= state->clip.y1) { >>> + /* Simple prechecks to eliminate entirely-invisible text. >>> + (This is only simple for non-rotated text.) >>> + FIXME this is probably broken for non left-to-right fonts. */ >>> + if (font->up_unit_x==0.0 && font->up_unit_y==-1.0 && >>> + (x > state->clip.x2 || y > state->clip.y2 || >>> + y + font->ascender - font->descender <= state->clip.y1)) { >>> return; >>> } >> >> That could explain the problem I had with few of the 270 degree cases. > > Hi, > > what's the status with this change? I'd like to include it in the new trunk > after releasing 1.2.0 ;)
Hi Denis, I'm still happily using 1.0 with my text-rotation and JPEG quality adjustment patches applied. I have not attempted to port it forward to your newer releases, partly because I've not had any need to upgrade my DirectFB core and also because ++DFB doesn't seem to have kept up. Regards, Phil. _______________________________________________ directfb-dev mailing list directfb-dev@directfb.org http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
