Vladimir Vukicevic wrote: > > On May 15, 2008, at 2:29 AM, Denis Oliver Kropp wrote: >> Denis Oliver Kropp wrote: >>> Vladimir Vukicevic wrote: >>>> Hi, >>>> >>>> The attached patch fixes two crashes in gdk-directfb (with Denis' >>>> patch that was posted a few days ago). In the first problem, >>>> gdk_keymap_translate_keyboard_state uses *effective_group even if >>>> the passed-in pointer is NULL. In the second, if a window is >>>> destroyed with pending updates before >>>> gdk_window_directfb_process_all_updates is called from the idle >>>> handler, gdk_window_get_toplevel will crash (as it does a simple >>>> while (window_type(obj) == child) obj = obj->parent; loop... parent >>>> is NULL for destroyed windows, so this blows up). >>>> >>>> (Also, I noticed that the patch accidentally uses d_debug_at in one >>>> place instead of D_DEBUG_AT, but I didn't include that fix here.) >>> Thanks! >>> I hope to get to finishing my patch and integrate your changes. >>> Do you have a working patch that includes all changes based on latest >>> git? >> >> Ooops, svn actually :) > > Yeah, too many VCS's :) What's working for me so far is your patch + > that small patch + s/d_debug_at/D_DEBUG_AT/ -- I can resend a big > combined patch if you'd like, but nothing else is in there other than that.
If it applies to latest svn, that would already be of great help :) -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | '------------------------------------------' _______________________________________________ directfb-dev mailing list directfb-dev@directfb.org http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
