I just scoped Cyrille's email...
here is the ?"proper"? for of the patch.
Thanx,
Mike
B.T.W I think I'm onto another bug... bug this time it's the diagrams in
the svg spec that are to blame :).
On Fri, 2002-08-30 at 11:36, Mike Sowka wrote:
> Hello,
> I've recently started using xml-docbook/svg for documenting my 4th year
> project... I managed to find some bugs in render_svg.c code. The bug
> occurs during rendering of arcs. It seems that the case of angles lying
> across 0degree boundary was not handled and the large-arc-flag was not
> being calculated properly... I've never sent a patch before... here it
> is. For some reason my svgs are still not getting rendered properly...
> but at least the large-arc-flag is fixed....
> Mike
> --
> /*******************************************************************\
> | Mike Sowka o _ _ _ |
> | An Aspiring Engi"Nerd" _o /\_ _ \\o (_)\__/o (_) |
> | Carleton University _< \_ _>(_) (_)/<_ \_| \ _|/' \/ |
> | [EMAIL PROTECTED] (_)>(_) (_) (_) (_) (_)' _\o_ |
> | (home [EMAIL PROTECTED]) |
> \*******************************************************************/
> --
> /*******************************************************************\
> | Mike Sowka o _ _ _ |
> | An Aspiring Engi"Nerd" _o /\_ _ \\o (_)\__/o (_) |
> | Carleton University _< \_ _>(_) (_)/<_ \_| \ _|/' \/ |
> | [EMAIL PROTECTED] (_)>(_) (_) (_) (_) (_)' _\o_ |
> | (home [EMAIL PROTECTED]) |
> \*******************************************************************/
> ----
>
> 667,673c667
> < int l_arc;
> <
> < if (angle2 > angle1) {
> < l_arc = (angle2 - angle1) > 180;
> < } else {
> < l_arc = (360 - angle2 + angle1) > 180;
> < }
> ---
> > int l_arc = (angle2 - angle1) > 180;
> 703,709c697
> < int l_arc;
> <
> < if (angle2 > angle1) {
> < l_arc = (angle2 - angle1) > 180;
> < } else {
> < l_arc = (360 - angle2 + angle1) > 180;
> < }
> ---
> > int l_arc = (angle2 - angle1) > 180;
--
/*******************************************************************\
| Mike Sowka o _ _ _ |
| An Aspiring Engi"Nerd" _o /\_ _ \\o (_)\__/o (_) |
| Carleton University _< \_ _>(_) (_)/<_ \_| \ _|/' \/ |
| [EMAIL PROTECTED] (_)>(_) (_) (_) (_) (_)' _\o_ |
| (home [EMAIL PROTECTED]) |
\*******************************************************************/
667,673c667
< int l_arc;
<
< if (angle2 > angle1) {
< l_arc = (angle2 - angle1) > 180;
< } else {
< l_arc = (360 - angle2 + angle1) > 180;
< }
---
> int l_arc = (angle2 - angle1) > 180;
703,709c697
< int l_arc;
<
< if (angle2 > angle1) {
< l_arc = (angle2 - angle1) > 180;
< } else {
< l_arc = (360 - angle2 + angle1) > 180;
< }
---
> int l_arc = (angle2 - angle1) > 180;
