Hi Knut, Sure, here's the issue: https://jira.dhis2.org/browse/DHIS2-2795
Thanks, - Jasper On Fri, Feb 2, 2018 at 1:42 PM Knut Staring <knu...@gmail.com> wrote: > Hi Jasper, > > Could you create an issue here: https://jira.dhis2.org ? > > Regards, > Knut > > On Fri, Feb 2, 2018 at 12:45 PM, Jasper Timm < > jasper.t...@ehealthnigeria.org> wrote: > >> Hi devs, >> >> I think I've spotted a couple of issues with completing data sets in Data >> Entry. >> >> There's a couple of uses of the completeDataSetRegistrations endpoint >> with ds,pe, e.t.c. params but it looks like it's expecting dataSet, period >> e.t.c. >> >> >> https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L2160 >> >> >> https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L3017 >> >> >> This AJAX call doesn't give a 'type' so it results in a GET, but I'm >> guessing it's supposed to be a POST: >> >> >> >> https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L402 >> >> Can I ask that this be backported as well? >> >> Thanks, >> >> - Jasper >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~dhis2-devs >> Post to : dhis2-devs@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~dhis2-devs >> More help : https://help.launchpad.net/ListHelp >> >> > > > -- > Knut Staring > > Department of Information, Evidence and Research > World Health Organization, Geneva, Switzerland > Office: +41 22 791 3683 <+41%2022%20791%2036%2083> Mob1: +33 6 4434 2931 > <+33%206%2044%2034%2029%2031> Mob2: +47 9188 0522 > Skype: knutstar >
_______________________________________________ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
